Re: apparent bug about check_free_strict
Oleg Drokin <[email protected]> Tue, 25 Nov 2025 10:34:49 -0500
| Newsgroups | org.kernel.vger.smatch |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2025-11-25 at 17:04 +0200, Toomas Soome wrote: > For positive side, the current smatch has been able to detect many > bugs the previous versions had missed - its definitely good progress. > While there are some issues, we can disable checks on such cases. > Only problem is that where previously =E2=80=94disable=3Dcheck_free_stric= t did > work, =E2=80=94disable=3Dcheck_free does not seem to:) The way I found to be the most impactful is to just keep a database of the warnings and then: 1. mark the clearly invalid ones so they don't pop up again 2. every time there's a new patch - see if anything new gets added. the new additions are the primary focus of new triage then since all the old ones were presumably checked already. if you make 2 execute before the patch is merged at the time of the review, you also get ability to add these warnings into the patch review process (I post to gerrit which is where we review our patches) and then reviewers could pay more attention in those areas (hopefully) just as the initial premise of static code analyzers was.