Re: [PATCH] smatch_scripts: Fix incomplete quoting in kchecker make command

Dan Carpenter <[email protected]> Mon, 15 Dec 2025 16:35:03 +0300
Newsgroups org.kernel.vger.smatch
Message-ID <[email protected]>
On Mon, Dec 15, 2025 at 05:05:18AM -0800, Harshit Mogalapalli wrote:
> The previous commit added quotes around some variables and that
> caused empty string arguments when variables are unset. Use
> conditional expansion to only quote when variables are set.
> 
> I see something like this
> 
> $ kchecker --spammy net/ethtool/ioctl.c
> make: *** empty string invalid as file name.  Stop.
> 
> Fixes: 9b3323efbe7f ("kchecker: Add quotes around variables")
> Signed-off-by: Harshit Mogalapalli <[email protected]>
> ---
> I have tested it on mine with no variables set, worth testing it when
> some of these varaibles are set as well.

Thanks!  Applied.

regards,
dan carpenter