Re: [xen 5/6] user_data: add register read function

I agree, that's a miss on my side, likely a copy&paste error, given the
copy from guest values are using the 0 here. I'll post an update.

On 08/14/2018 07:08 PM, Dan Carpenter wrote:
> On Tue, Aug 14, 2018 at 05:00:57PM +0200, Norbert Manthey wrote:
>> Signed-off-by: Norbert Manthey <[email protected]>
>> ---
>>  check_user_data2.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/check_user_data2.c b/check_user_data2.c
>> index 5d5606c..d95ba1d 100644
>> --- a/check_user_data2.c
>> +++ b/check_user_data2.c
>> @@ -1238,6 +1238,9 @@ void check_user_data2(int id)
>>  	for (i = 0; i < ARRAY_SIZE(xen_from_guest_funcs); i++)
>>  		add_function_hook(xen_from_guest_funcs[i], &match_user_copy, INT_PTR(0));
>>  
>> +        // the Xen equivalent to kvm_register_read
>> +	add_function_assign_hook("acpi_hw_register_read", &match_user_copy, NULL);
>                                                                             ^^^^
> This should be INT_PTR(1) because it's supposed to say which parameter
> gets set.  It start counting parameters from zero.
> 
> regards,
> dan carpenter
> 
> 
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B