Re: [xen 4/6] user_data: match Xen copy_from_guest

I've been running smatch against several versions of Xen, and these
functions are present prior to version 4.9. You grep should still work
if you go to tag RELEASE-4.8.0, or earlier versions.

While some people might only be interested in running against the most
recent version, others might be interested in all supported versions.
Hence, I added those functions as well.

Best,
Norbert

On 08/14/2018 07:27 PM, Dan Carpenter wrote:
> On Tue, Aug 14, 2018 at 05:00:56PM +0200, Norbert Manthey wrote:
>> Add functions that access guest data, and teach smatch about the
>> parameter that points to the user data. As there are multiple
>> flavors, try to be exhaustive.
>>
>> Signed-off-by: Norbert Manthey <[email protected]>
>> ---
>>  check_user_data2.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/check_user_data2.c b/check_user_data2.c
>> index a556bb8..5d5606c 100644
>> --- a/check_user_data2.c
>> +++ b/check_user_data2.c
>> @@ -49,6 +49,15 @@ static const char *returns_user_data[] = {
>>  	"kmap_atomic", "skb_network_header",
>>  };
>>  
>> +// in Xen, these functions are called "copy_from_guest"
>> +static const char * xen_from_guest_funcs[] = {
>> +"copy_from_guest", "__copy_from_guest", "copy_from_guest_offset",
>> +"copy_from_user_hvm", "__raw_copy_from_guest", "__copy_from_user",
>> +"__hvm_copy", "hvm_copy_from_guest_phys", "hvm_copy_from_guest_virt",
>> +"hvm_fetch_from_guest_virt", "hvm_copy_from_guest_virt_nofault",
>> +"hvm_fetch_from_guest_virt_nofault",
> 
> Where are these hvm_ functions from?  I grepped for
> hvm_fetch_from_guest_virt but couldn't find it.
> 
> regards,
> dan carpenter
> 
> 
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B