Re: [PATCH] arch/sparc32: remove unused variable strtab
Alex Shi <[email protected]>
| Newsgroups | org.kernel.vger.sparclinux |
|---|---|
| Message-ID | <CAJy-AmkEEyC=6h=n4K7Ns4wC-jWP_ubNmC7_ZZww3WHKSus5Bw@mail.gmail.com> |
Andreas Larsson <[email protected]> 于2026年1月27日周二 00:54写道: > > > [PATCH] arch/sparc32: remove unused variable strtab > > Although the commit that made it unused did changes for sparc32, this > cleanup is not only for sparc32. Also, no need for the "arch/". Please > use "sparc:" instead of "arch/sparc32". Got it. Thanks for point it out. I will fix it in next version. > > > On 2026-01-12 07:37, [email protected] wrote: > > From: Alex Shi <[email protected]> > > > > The commit 1b35a57b1c178 ("sparc32: Kill off software 32-bit multiply/divide > > routines") removed the last usage of strtab in funtion module_frob_arch_sections > > Therefore, it can be removed now. > > > > Reported-by: kernel test robot <[email protected]> > > Did the kernel test robot also suggest a "Closes:" line as well? If so, > please also add that. This issue is also found in a lkp report for my testing code on sparc. In that report, lkp just focus on my another issue. But since it is just a simple change, is it fine without the 'Closes'? Thanks Alex