Re: [PATCH] sparc: vio: Replace snprintf with strscpy in vio_create_one
Andreas Larsson <[email protected]>
| Newsgroups | org.kernel.vger.sparclinux,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 2026-01-31 23:44, Thorsten Blum wrote:
> Replace snprintf("%s", ...) with the faster and more direct strscpy().
>
> Signed-off-by: Thorsten Blum <[email protected]>
> ---
> arch/sparc/kernel/vio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
> index 1a1a9d6b8f2e..8c7dd72ef334 100644
> --- a/arch/sparc/kernel/vio.c
> +++ b/arch/sparc/kernel/vio.c
> @@ -12,6 +12,7 @@
>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> +#include <linux/string.h>
> #include <linux/irq.h>
> #include <linux/export.h>
> #include <linux/init.h>
> @@ -378,8 +379,7 @@ static struct vio_dev *vio_create_one(struct mdesc_handle *hp, u64 mp,
> * the parent doesn't require the MD node info.
> */
> if (node_name != NULL) {
> - (void) snprintf(vdev->node_name, VIO_MAX_NAME_LEN, "%s",
> - node_name);
> + strscpy(vdev->node_name, node_name);
>
> err = mdesc_get_node_info(hp, mp, node_name,
> &vdev->md_node_info);
Reviewed-by: Andreas Larsson <[email protected]>
Picking this up to my for-next.
Thanks,
Andreas