Re: [PATCH 01/25] xor: assert that xor_blocks is not called from interrupt context
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.sparclinux,dev.linux.lists.loongarch,org.infradead.lists.linux-riscv,org.infradead.lists.linux-um,org.kernel.vger.linux-alpha,org.kernel.vger.linux-arch,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel,org.kernel.vger.linux-raid,org.kernel.vger.linux-s390,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Feb 27, 2026 at 03:24:55PM +0100, Peter Zijlstra wrote: > > unsigned long *p1, *p2, *p3, *p4; > > > > + WARN_ON_ONCE(in_interrupt()); > > Your changelog makes it sound like you want: > > WARN_ON_ONCE(!in_task()); > > But perhaps something like so: > > lockdep_assert_preempt_enabled(); > > Would do? That ensures we are in preemptible context, which is much the > same. That also ensures the cost of this assertion is only paid on debug > kernels. No idea honestly. The kernel FPU/vector helpers generally don't work from irq context, and I want to assert that. Happy to do whatever version works best for that.