Re: Does the SPARC optimized crypto and CRC code actually work?

On 17/3/26 04:42, Eric Biggers wrote:
> Hi,
>
> The Linux kernel contains various SPARC crypto opcodes optimized
> functions in lib/crypto/sparc/, lib/crc/sparc/, and arch/sparc/crypto/.
>
> As the kernel's crypto and CRC code has been refactored over time, we've
> been updating how the SPARC optimized code is integrated accordingly.
> However, QEMU doesn't support the SPARC crypto opcodes, which means that
> even though I (and maybe others) been running the tests on SPARC kernels
> in QEMU, this doesn't actually execute the SPARC optimized code.
>
> So I have to ask: is someone in the SPARC community actually testing
> this code regularly?  That includes running all the KUnit tests for
> crypto and CRC as well as the traditional crypto self-tests.
>
> If not, then unless QEMU support is forthcoming I'd suggest we drop this
> code to avoid issues on SPARC systems.  The generic code is much better
> tested and we know that it works on any architecture, including SPARC.
> Correctness is the first priority, especially for cryptography.
>
> - Eric
>
I've been testing some of the PCI changes that have come through on my 
T5-2. I'll happily add some tests for the crypto functions, I've just 
got no idea how to do so.