Re: [PATCH] sparc64: uprobes: add missing break
Masami Hiramatsu (Google) <[email protected]>
| Newsgroups | org.kernel.vger.sparclinux,org.kernel.vger.linux-kernel,org.kernel.vger.linux-trace-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 5 May 2026 20:18:15 -0700 Rosen Penev <[email protected]> wrote: > Missing fallthrough causes failure with newer compilers: > > arch/sparc/kernel/uprobes.c:284:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > 284 | default: > | ^ > arch/sparc/kernel/uprobes.c:284:2: note: insert 'break;' to avoid fall-through > 284 | default: > | ^ > | break; > > Signed-off-by: Rosen Penev <[email protected]> Looks good to me. Reviewed-by: Masami Hiramatsu (Google) <[email protected]> > --- > arch/sparc/kernel/uprobes.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sparc/kernel/uprobes.c b/arch/sparc/kernel/uprobes.c > index 305017bec164..c8cac64e9988 100644 > --- a/arch/sparc/kernel/uprobes.c > +++ b/arch/sparc/kernel/uprobes.c > @@ -280,6 +280,7 @@ int arch_uprobe_exception_notify(struct notifier_block *self, > case DIE_SSTEP: > if (uprobe_post_sstep_notifier(args->regs)) > ret = NOTIFY_STOP; > + break; > > default: > break; > -- > 2.54.0 > -- Masami Hiramatsu (Google) <[email protected]>