Re: [PATCH v3 1/6] scsi: core: Remove remaining reference to the pktcdvd driver

Geert Uytterhoeven <[email protected]> Fri, 5 Jun 2026 09:30:35 +0200
Newsgroups org.kernel.vger.sparclinux,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sh,org.ozlabs.lists.linuxppc-dev
Message-ID <CAMuHMdVhjYBhKUPzx-FAKWAAkUwcpYh0v2V5w64OMJtREZr4PQ@mail.gmail.com>
Hoi Bart,

On Thu, 4 Jun 2026 at 18:01, Bart Van Assche <[email protected]> wrote:
> On 6/4/26 6:20 AM, Catalin Iacob wrote:
> > Commit 1cea5180f2f8 ("block: remove pktcdvd driver") left behind an
> > export that is now dead code. Remove it.
> The subject should say something like "Unexport
> scsi_device_from_queue()".

<pedantic>
But that is not what it does: the symbol is never exported, as
CONFIG_CDROM_PKTCDVD_MODULE can never be set?
</pedantic>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds