Re: [PATCH v2 3/3] mm: cleanup clear_not_present_full_ptes() and rename to clear_non_present_ptes()

On Mon, Jun 29, 2026 at 03:49:49PM +0200, David Hildenbrand (Arm) wrote:
>Let's clean it up a bit:
>
>(1) There is no need to pass "full" anymore.
>
>(2) No architecture overwrites it, and there isn't really a good reason
>    to do so when dealing with non-resent PTEs.

Nit: "non-resent PTEs" -> "non-present PTEs".

>
>(3) While at it, call it "non-present", similar to copy_nonpresent_pte()
>    and zap_nonpresent_ptes().
>
>It's a shame that we have clear_non_present_ptes() correspond to
>pte_clear() and clear_ptes() correspond to ptep_get_and_clear*().
>
>Reviewed-by: Oscar Salvador (SUSE) <[email protected]>
>Signed-off-by: David Hildenbrand (Arm) <[email protected]>
>---

Nice cleanup! Feel free to add:

Reviewed-by: Lance Yang <[email protected]>