Re: [External] : Re: Please backport: netfilter: nft_counter: Use u64_stats_t for statistic.

On 2024-10-04 15:14:52 [-0400], Joseph Salisbury wrote:
> I attempted a backport of commit 4a1d3acd6ea8 to v5.15-rt.  Commit
> 4a1d3acd6ea8 removes nft_counter_seq() from most places, but in v5.15 it is
> still in: nft_counter_module_init():
> 
> ...
> ...
> ...
> static int __init nft_counter_module_init(void)
> {
>         int cpu, err;
> 
>         for_each_possible_cpu(cpu)
>                 seqcount_init(per_cpu_ptr(*&nft_counter_seq*, cpu));

This should have been
		seqcount_init(per_cpu_ptr(&nft_counter_seq, cpu));

in 5.15 and should work to be replaced as
		u64_stats_init(per_cpu_ptr(&nft_counter_sync, cpu));

I *think* the API was the same in 5.15.

…
> It looks like your patch handles this in nft_counter_init_seqcount().  I
> believe I can just backport the same into in nft_counter_module_init() for
> v5.15, but I wanted to run it by you.

You probably do the right thing. If in doubt just do it and post it for
review.

> Thanks,
> 
> Joe