Re: [PATCH v2] vdpa: solidrun: Free IRQs after request failure

Markus Elfring <[email protected]>
Newsgroups org.kernel.vger.stable,dev.linux.lists.virtualization,org.kernel.vger.linux-kernel
Message-ID <[email protected]> 
> Unwind IRQs already requested by snet_request_irqs() before returning a
> VQ IRQ request error so a later DRIVER_OK retry starts from a clean
> state. The IRQs are requested and freed while the PCI device remains
> bound, so the driver cannot wait for devres cleanup at detach time.

I suggest to avoid duplicate SNET_ERR() calls for the implementation
of the function “snet_request_irqs”.
https://elixir.bootlin.com/linux/v7.2-rc5/source/drivers/vdpa/solidrun/snet_main.c#L400-L426

Regards,
Markus
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.