Re: [PATCH] zram: freeze device queue before device reset
Sergey Senozhatsky <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mmc |
|---|---|
| Message-ID | <[email protected]> |
On (26/08/05 19:29), Sergey Senozhatsky wrote:
> On (26/08/05 11:18), Sergey Senozhatsky wrote:
> > Device reset does not take into account in-flight async IO
> > requests so we can free meta table and reset device concurrently
> > with those requests being executed. The block layer guidelines
> > indicate that queue state should be protected by blk_mq_freeze_queue()
> > during teardown. Freeze zram queue before device reset.
> >
> > Fixes: cd67e10ac699 ("zram: promote zram from staging")
> > Link: https://sashiko.dev/#/patchset/[email protected]
> > Cc: [email protected]
> > Signed-off-by: Sergey Senozhatsky <[email protected]>
>
> lockdep doesn't seem to be happy...
> Let me look into it.
Actually I need to look at the report again. I suspect that we
maybe don't even need any patches for that "async IO vs reset"
sashiko report.