Re: [PATCH net v5 2/2] packet: use consistent hard_header_len in TX_RING send path
Willem de Bruijn <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Jakub Kicinski wrote: > On Mon, 03 Aug 2026 23:04:54 -0400 Willem de Bruijn wrote: > > If I read Gemini feedback correctly, all reports are about the current > > solution falling short of fixing the instance of this race condition > > with dev_hard_header(), which reads dev->hard_header_len directly. > > The patch indeed mentions this limitation. > > To be clear -- prefer looking that the netdev-ai instance. > It cross reviews the feedback with different LLMs > > > As well as the same issue with dev_validate_header(), which the commit > > does not list as limitation. But that one is only reached with variable > > length L2 protocols. > > > > Side note, in net-next I can probably remove header_ops.validate now > > that ax25 is gone, and with that all of dev_validate_header. No other > > variable length L2 protocol ever implemented that callback. > > Let's do it. Ack. Once this fix lands and makes its way to net-next.