Re: [PATCH] i2c: designware-pci: fix autosuspend cleanup during teardown
Mika Westerberg <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Aug 09, 2026 at 03:30:55PM +0800, Guangshuo Li wrote:
> i2c_dw_pci_probe() calls pm_runtime_use_autosuspend(), but
> i2c_dw_pci_remove() does not call the matching
> pm_runtime_dont_use_autosuspend() during teardown.
>
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during teardown, this reference is not dropped.
>
> The documentation for pm_runtime_use_autosuspend() also notes that it
> is important to undo it with pm_runtime_dont_use_autosuspend() at
> driver exit time, unless runtime PM was initially enabled with
> devm_pm_runtime_enable().
>
> Add the missing pm_runtime_dont_use_autosuspend() call to the driver
> remove path.
>
> This issue was found by manual code inspection.
>
> Fixes: 18dbdda89f5c ("i2c-designware: Add runtime power management support")
> Cc: [email protected]
> Signed-off-by: Guangshuo Li <[email protected]>
Acked-by: Mika Westerberg <[email protected]>