Re: [PATCH 1/2] KVM: arm64: nv: Allocate the shadow S2 MMUs individually
Karl Mehltretter <[email protected]>
| Newsgroups | org.kernel.vger.stable,dev.linux.lists.kvmarm,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 10, 2026 at 08:58:12AM +0100, Marc Zyngier wrote:
> > The increment expression of the for loop still runs after an error.
>
> Yup. Should be fixed with
> + for (i = 0; !ret && i < S2_MMU_PER_VCPU; i++) {
> ret = init_nested_s2_mmu(kvm, &tmp[i]);
> + if (ret)
> + break;
> + }
Yes, that fixes the cleanup issue. I have no other concerns with the patch.
Thanks,
Karl