Re: [PATCH] KVM: x86: Check for invalid/obsolete root *after* making MMU pages available
Sasha Levin <[email protected]>
| Newsgroups | org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
> Conflicts: > arch/x86/kvm/mmu/mmu.c > arch/x86/kvm/mmu/paging_tmpl.h The 6.1 resolution has two problems I think. The new call sites pass two arguments, but 6.1 declares is_page_fault_stale(vcpu, fault, mmu_seq) - so I'm not sure why you're not seeing a build breakage. Upstream could move the check because direct_page_fault() is shadow-MMU-only there. On 6.1 it still serves both MMUs and dispatches on is_tdp_mmu_fault, so relocating the check into the shadow arm leaves kvm_tdp_mmu_map() with no check and no mmu_invalidate_retry_hva() retry. -- Thanks, Sasha