[PATCH] i2c: nvidia-gpu: fix autosuspend cleanup

Guangshuo Li <[email protected]>
Newsgroups org.kernel.vger.stable,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
gpu_i2c_probe() calls pm_runtime_use_autosuspend(), but the remove
path does not call the matching pm_runtime_dont_use_autosuspend().

If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without undoing the autosuspend setting during
teardown, this reference is not dropped and usage_count remains
unbalanced.

Call pm_runtime_dont_use_autosuspend() during driver removal to
properly undo the autosuspend setting.

This issue was found by manual code inspection.

Fixes: d4a4f927e4dd ("i2c: nvidia-gpu: add runtime pm support")
Cc: [email protected]
Signed-off-by: Guangshuo Li <[email protected]>
---
 drivers/i2c/busses/i2c-nvidia-gpu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
index 14c059b03945..9dbe1fe22412 100644
--- a/drivers/i2c/busses/i2c-nvidia-gpu.c
+++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
@@ -334,6 +334,7 @@ static void gpu_i2c_remove(struct pci_dev *pdev)
 	struct gpu_i2c_dev *i2cd = pci_get_drvdata(pdev);
 
 	pm_runtime_get_noresume(i2cd->dev);
+	pm_runtime_dont_use_autosuspend(i2cd->dev);
 	i2c_del_adapter(&i2cd->adapter);
 	pci_free_irq_vectors(pdev);
 }
-- 
2.43.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.