Re: [PATCH net v3 0/2] net: thunderbolt: two fixes for the failed bring-up path
Simon Horman <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 11, 2026 at 01:20:48PM +0000, Fan Ye via B4 Relay wrote: > Two separate defects reached through the same branch in > tbnet_connected_work(), found on an ASMedia ASM4242 host-to-host link > when the peer drops out while a connection is being brought up. > > 1 releases the HopID the allocator handed out when it is not the one > that was asked for. Today it stays allocated for the rest of the > XDomain connection. > > 2 marks the connection down on the failure paths, so the next > tbnet_tear_down() does not run a second teardown over work that was > already undone: stopping rings that are already stopped, which is > fatal under panic_on_warn, and handing back a HopID this connection > never owned. > > Patch 2 edits the lines patch 1 adds, so it has to come second. > > Changes in v3: > - Cut both commit messages down after review; the code is unchanged > apart from the comment on the new helper in patch 2, now one line. > - Link to v2: https://lore.kernel.org/netdev/[email protected]/ For the series: Reviewed-by: Simon Horman <[email protected]>