Re: [PATCH] pinctrl: renesas: rzg2l: Use -ENOTSUPP instead of -EOPNOTSUPP
Claudiu Beznea <[email protected]>
| Newsgroups | org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
Hi, Please ignore this and the other similar ones. I missed to mention the target branch. Thank you, Claudiu On 8/14/26 17:27, Claudiu Beznea wrote: > From: Claudiu Beznea <[email protected]> > > commit c1492da3939c89372929e062d731f328f7693f1e upstream. > > The pinctrl and GPIO core code make exceptions for the -ENOTSUPP error > code. One such example is gpio_set_config_with_argument_optional(), > which returns success when gpio_set_config_with_argument() returns > -ENOTSUPP, but reports failure for all other error codes. > > Returning -EOPNOTSUPP from the pinctrl driver on the unsupported pinctrl > operation may lead to boot failures when pinctrl drivers implements > struct gpio_chip::set_config, the system uses GPIO hogs, and the > struct gpio_chip::set_config implementation returns -EOPNOTSUPP for the > unsupported operations. > > Return -ENOTSUPP for the unsupported pinctrl operation. > > Fixes: 560c633d378a ("pinctrl: renesas: rzg2l: Drop oen_read and oen_write callbacks") > Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver") > Cc: [email protected] > Signed-off-by: Claudiu Beznea <[email protected]> > Reviewed-by: Bartosz Golaszewski <[email protected]> > Reviewed-by: Geert Uytterhoeven <[email protected]> > Tested-by: Geert Uytterhoeven <[email protected]> > Link: https://patch.msgid.link/[email protected] > Signed-off-by: Geert Uytterhoeven <[email protected]> > [claudiu.beznea: fixed conflict by dropping the code not present in > v6.6 stable] > Signed-off-by: Claudiu Beznea <[email protected]> > --- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > index ac629c72d592..b713cc8e0fde 100644 > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c > @@ -710,7 +710,7 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev, > } > > default: > - return -EOPNOTSUPP; > + return -ENOTSUPP; > } > } > > @@ -759,7 +759,7 @@ static int rzg2l_pinctrl_pinconf_group_get(struct pinctrl_dev *pctldev, > > /* Check config matching between to pin */ > if (i && prev_config != *config) > - return -EOPNOTSUPP; > + return -ENOTSUPP; > > prev_config = *config; > }