Re: [PATCH] nvme-fc: fix double free of fabrics options when nvme_add_ctrl() fails

Keith Busch <[email protected]>
Newsgroups org.kernel.vger.stable,org.infradead.lists.linux-nvme
Message-ID <aohiPzxHPKtUT_E8@kbusch-mbp>
On Fri, Aug 21, 2026 at 08:18:31AM -0600, Keith Busch wrote:
> I think you're relying on nvme_fc_init_ctrl's nvme_put_ctrl() error case
> to be the final reference, but it might not be if the character device
> was created and someone opened it. If so then:

And a successful open requires the ctrl state is live, which it is not,
so it is always the last reference as needed. Okay, please let's forget
I've said in this thread!
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.