Re: [PATCH v2 0/5] Stop TIF_NOTIFY_SIGNAL from interrupting work that can't be restarted
Oleg Nesterov <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.bpf,org.kernel.vger.linux-cifs,org.kernel.vger.linux-fsdevel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 08/24, Christian Brauner wrote: > > Christian Brauner (5): > signal: allow taks to temporarily block TIF_NOTIFY_SIGNAL > coredump: prevent TIF_NOTIFY_SIGNAL from interrupting coredumps > selftests/coredump: test that TIF_NOTIFY_SIGNAL doesn't truncate a coredump > smb: prevent TIF_NOTIFY_SIGNAL from interrupting > pid_namespace: prevent TIF_NOTIFY_SIGNAL from interrupting the reaper For 1-2 and 4-5 feel free to add Reviewed-by: Oleg Nesterov <[email protected]> ------------------------------------------------------------------------------- sigprocmask(SIG_BLOCK) in fs/smb/client/transport.c:__smb_send_rqst() looks a bit suspicious. Even if we forget about TIF_NOTIFY_SIGNAL, sigprocmask() doesn't necessarily clear TIF_SIGPENDING, nor it can protect from (say) do_signal_stop()->signal_wake_up() from a sub-thread. But this is offtopic. Oleg.