Re: [PATCH 1/3] drm/xe/guc_ads: allocate UM queues in a separate BO
Greg KH <[email protected]>
| Newsgroups | org.kernel.vger.stable |
|---|---|
| Message-ID | <2026082417-detonate-glacial-6417@gregkh> |
On Mon, Aug 24, 2026 at 04:52:06PM +0000, Jia Yao wrote:
> Move the UM queues into a dedicated BO (ads->um_queue_bo) and avoid
> CPU memset operations on it, which eliminates the CPU as a potential
> cacheline-polluting agent and helps maintain consistency between GAM
> writes and GuC reads.
>
> We also need to ensure the base_dpa for the queue is contiguous on hw
> where this is used instead of a GGTT address. Another good reason to
> split this out to a separate BO.
>
> Fixes: 9c57bc08652a ("drm/xe/lnl: Drop force_probe requirement")
> Cc: Gwan-gyeong Mun <[email protected]>
> Cc: Matthew Auld <[email protected]>
> Cc: <[email protected]> # v6.12+
> Signed-off-by: Jia Yao <[email protected]>
> Reviewed-by: Matthew Auld <[email protected]>
> Signed-off-by: Matthew Auld <[email protected]>
> Link: https://patch.msgid.link/[email protected]
> (cherry picked from commit 6af05de0dc19bbf3aaeec2020fe48b37c834b811)
> Signed-off-by: Thomas Hellström <[email protected]>
> (cherry picked from commit 99b01815957bd7d848420cb697f79ed11f7f215c)
> ---
> drivers/gpu/drm/xe/xe_bo.h | 14 +++++
> drivers/gpu/drm/xe/xe_guc.c | 6 ++
> drivers/gpu/drm/xe/xe_guc_ads.c | 90 +++++++++++++++++----------
> drivers/gpu/drm/xe/xe_guc_ads_types.h | 5 ++
> 4 files changed, 83 insertions(+), 32 deletions(-)
What stable tree(s) are these patches for?
And what's with the crazy 2 cherry picked lines? You all know better
than to attempt to mess this up even more...