RE: [PATCH 1/3] drm/xe/guc_ads: allocate UM queues in a separate BO
"Yao, Jia" <[email protected]>
| Newsgroups | org.kernel.vger.stable |
|---|---|
| Message-ID | <PH8PR11MB8040FC3EA4D1AAA6A521AFBBF4AF2@PH8PR11MB8040.namprd11.prod.outlook.com> |
Resent the patches after removing the redundant cherry-pick information and adding the correct subject. > -----Original Message----- > From: Yao, Jia > Sent: Monday, August 24, 2026 10:13 AM > To: 'Greg KH' <[email protected]> > Cc: [email protected]; Mun, Gwan-gyeong <Gwan- > [email protected]>; Auld, Matthew <[email protected]>; > Thomas Hellström <[email protected]> > Subject: RE: [PATCH 1/3] drm/xe/guc_ads: allocate UM queues in a separate > BO > > This fix is intended for all stable trees containing commit 9c57bc08652a > ("drm/xe/lnl: Drop force_probe requirement"). > > Regarding the duplicate cherry-pick annotations, 99b01815957b was itself > cherry-picked from 6af05de0dc19 and the extra annotation was carried over > inadvertently. One of the cherry-picked lines can be dropped. > > > -----Original Message----- > > From: Greg KH <[email protected]> > > Sent: Monday, August 24, 2026 10:03 AM > > To: Yao, Jia <[email protected]> > > Cc: [email protected]; Mun, Gwan-gyeong <gwan- > > [email protected]>; Auld, Matthew <[email protected]>; > Thomas > > Hellström <[email protected]> > > Subject: Re: [PATCH 1/3] drm/xe/guc_ads: allocate UM queues in a > > separate BO > > > > On Mon, Aug 24, 2026 at 04:52:06PM +0000, Jia Yao wrote: > > > Move the UM queues into a dedicated BO (ads->um_queue_bo) and avoid > > > CPU memset operations on it, which eliminates the CPU as a potential > > > cacheline-polluting agent and helps maintain consistency between GAM > > > writes and GuC reads. > > > > > > We also need to ensure the base_dpa for the queue is contiguous on > > > hw where this is used instead of a GGTT address. Another good reason > > > to split this out to a separate BO. > > > > > > Fixes: 9c57bc08652a ("drm/xe/lnl: Drop force_probe requirement") > > > Cc: Gwan-gyeong Mun <[email protected]> > > > Cc: Matthew Auld <[email protected]> > > > Cc: <[email protected]> # v6.12+ > > > Signed-off-by: Jia Yao <[email protected]> > > > Reviewed-by: Matthew Auld <[email protected]> > > > Signed-off-by: Matthew Auld <[email protected]> > > > Link: > > > https://patch.msgid.link/[email protected] > > > (cherry picked from commit > > 6af05de0dc19bbf3aaeec2020fe48b37c834b811) > > > Signed-off-by: Thomas Hellström <[email protected]> > > > (cherry picked from commit > > 99b01815957bd7d848420cb697f79ed11f7f215c) > > > --- > > > drivers/gpu/drm/xe/xe_bo.h | 14 +++++ > > > drivers/gpu/drm/xe/xe_guc.c | 6 ++ > > > drivers/gpu/drm/xe/xe_guc_ads.c | 90 +++++++++++++++++---------- > > > drivers/gpu/drm/xe/xe_guc_ads_types.h | 5 ++ > > > 4 files changed, 83 insertions(+), 32 deletions(-) > > > > What stable tree(s) are these patches for? > > > > And what's with the crazy 2 cherry picked lines? You all know better > > than to attempt to mess this up even more...