Re: [PATCH v6 0/6] panic: fix panic_force_cpu= redirect races and NMI bypass

On Tue 2026-08-18 19:45:47, Bradley Morgan wrote:
> On 18 August 2026 19:41:58 BST, Andrew Morton <[email protected]>
> wrote:
> >On Tue, 18 Aug 2026 16:38:00 +0000 Bradley Morgan <[email protected]>
> >wrote:
> >
> >> The panic_force_cpu= parameter redirects a panic to a specific CPU so
> >> the crash kernel runs there. The redirect code in panic_try_force_cpu()
> >> had two races and an NMI bypass, all found by Sashiko. This series
> >> closes them and kills one more hack that the rework turned up.
> >
> >Thanks.  Sashiko had more to say:
> >	https://sashiko.dev/#/patchset/[email protected]
> >
> >In the first one it suggests va_copy(), but perhaps this would be
> >better addressed with va_end/va_start.
> >
> 
> Sashiko said there was ANOTHER bug, I might just screammm, at this point,
> some sort of superhero needs to come by and suggest the fix that sashiko
> likes :sob:

We are all still learning how to deal with Sashiko. It is quite good
at finding problems. We always have to decide/agree on what is worth
fixing and what is not worth it.

I described my opinion in replies to the particular patches.

Anyway, we are getting close. I believe that v7 will be final ;-)

Best Regards,
Petr