Re: [PATCH net v2] net: fix spurious TX timeout after dev_activate()

On Tue, Aug 25, 2026 at 6:56 PM Breno Leitao <[email protected]> wrote:
>
> While debugging another issue today, I found out that my TX queue is
> reported as stopped for 4294907392 ms (49.7 days), on a machine that
> had been up for four minutes.
>
>     bnxt_en 0002:01:00.0 eth0: NETDEV WATCHDOG: CPU: 28: transmit queue 23 timed out 4294907392 ms
>
> 4294907392 is not an elapsed time. It is the value of jiffies at that
> moment: INITIAL_JIFFIES is 4294667296, which leaves jiffies 59 seconds
> short of wrapping.
>
> dev_activate() runs transition_one_qdisc() over every TX queue, which
> resets trans_start to 0, and then stamps only queue 0 through
> netif_trans_update().
>
> Stamp jiffies instead. A queue stopped across dev_activate() now gets a
> full watchdog_timeo of grace, and is still reported if it is stopped
> that long.
>
> Fixes: 9b36627acecd ("net: remove dev->trans_start")
> Cc: [email protected]
> Signed-off-by: Breno Leitao <[email protected]>
> Reviewed-by: Nicolai Buchwitz <[email protected]>

Reviewed-by: Jason Xing <[email protected]>

Thanks!