Re: [PATCH linux-6.1.y linux-6.6.y linux-6.12.y 0/1] ndisc: backport ndisc_send_redirect() cleanup
Sasha Levin <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 24, 2026 at 09:38:51PM +0800, Li Xiasong wrote: > dbc3791e3b24 adds "if (!peer) goto release;" inside > rcu_read_lock()/rcu_read_unlock() in ndisc_send_redirect(), > which seems to leak the read lock on the NULL-peer path on > these trees. This cleanup drops the pair (callers already hold > rcu_read_lock()), so the leak would go away. Correct, and confirmed here - ip6_forward() already wraps the call in rcu_read_lock() on all three trees. Queued for 6.12, 6.6 and 6.1, thanks. -- Thanks, Sasha