Re: [PATCH v2] mm/secretmem: properly account locked pages
"David Hildenbrand (Arm)" <[email protected]>
| Newsgroups | org.kernel.vger.stable,org.kernel.vger.bpf,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
>>>
>>> + if (!secretmem_account_folio(state, folio)) {
>>> + folio_put(folio);
>>> + ret = VM_FAULT_SIGBUS;
>>> + goto out;
>>> + }
>>> +
>> Okay, that works because secretmem does not support any form of truncate, in
>> particular, no FALLOC_FL_PUNCH_HOLE.
>
> Yeah exactly. I think I covered that off somewhere in my essay-length
> commit msg but if not but yeah that is a thing that I noted.
I didn't quickly spot it, but it would be worth adding it if not already there.
>
>>
>> Overall, the idea sounds good to me. Nothing jumped at me.
>
> Thanks! So in a way you kinda... Ack it right? :P If only there were a tag
> for that 🤔 ;)
Well, on the split patch without the test ;)
Acked-by: David Hildenbrand (Arm) <[email protected]>
--
Cheers,
David