Re: [PATCH] util.h: correct range check of str_to_int_gt() and str_to_int_lt()
FUJITA Tomonori <[email protected]>
| Newsgroups | org.kernel.vger.stgt |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 10 Dec 2013 13:49:47 +0900 Ryusuke Konishi <[email protected]> wrote: > The range checks of str_to_int_gt() and str_to_int_lt() are not > implemented literally. The current definitions fail to reject a > marginal value. > > Due to this difference, tgtd accepts option "-t 0" without an error, > which overrides nr_iothreads to 0 and causes clients to hang. > > This corrects str_to_int_gt()/str_to_int_lt() and prevents the issue. > > Signed-off-by: Ryusuke Konishi <[email protected]> > --- > usr/util.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Nice catch, thanks!