Re: [PATCH 1/2] Fix bs_rbd.c slurp_to_semi() not consuming terminating semicolon

Reviewed-by: Dan Mick <[email protected]>

On 01/21/2014 06:14 PM, Thomas Matysik wrote:
> slurp_to_semi() would not consume the terminating semicolon on a
> option specified in --bsopts, so any options other than the first
> would be ignored as invalid.
>
> Signed-off-by: Thomas Matysik <[email protected]>
> ---
>   usr/bs_rbd.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/usr/bs_rbd.c b/usr/bs_rbd.c
> index 3ea9d36..f797fd5 100644
> --- a/usr/bs_rbd.c
> +++ b/usr/bs_rbd.c
> @@ -480,6 +480,9 @@ static char *slurp_to_semi(char **p)
>   	strncpy(ret, *p, len);
>   	ret[len] = '\0';
>   	*p = end;
> +	// Jump past the semicolon, if we stopped at one
> +	if (**p == ';')
> +		*p = end + 1;
>   	return ret;
>   }
>
>