Re: [PATCH] tgtd: fix internal error of __inaccount_bind()
FUJITA Tomonori <[email protected]>
| Newsgroups | org.kernel.vger.stgt |
|---|---|
| Message-ID | <20140226.171134.1568838937885763670.fujita.tomonori@lab.ntt.co.jp> |
On Mon, 24 Feb 2014 15:43:26 +0900 Ryusuke Konishi <[email protected]> wrote: > When trying to bind 32 accounts to the same target, tgtadm outputs > "unknown error" and exits returing status code 22 (EINVAL). > > This is because __inaccount_bind() function of tgtd does not increment > target->account.nr_inaccount when it doubles maximum number of > accounts for the target, and therefore it tries to allocate an aid > slot on target->account.in_aids[] array even though no free aid slot > is available there. > > This fixes the bug. > > Reported-by: Satoshi Yoshida <[email protected]> > Signed-off-by: Ryusuke Konishi <[email protected]> > --- > usr/target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good, thanks a lot!