Re: [PATCH] Fix segfault if device_type set to pt but bstype not sg or bsg

On Tue, 18 Mar 2014 11:02:02 -0700
Andy Grover <[email protected]> wrote:

> If bstype not set to sg or bsg, it will default to rdwr, and we will
> call target_cmd_perform instead of target_cmd_perform_passthrough when
> accessing the device, which crashes tgtd. There's an existing check for
> setting bstype without setting dev_type, but also add a check the other
> way, setting dev_type without setting bstype to a valid value for pt.
> 
> Add an error message to the existing check, as well.
> 
> Signed-off-by: Andy Grover <[email protected]>
> ---
>  usr/target.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Applied, thanks a lot!