Re: Little bug in STGT

FUJITA Tomonori <[email protected]> Wed, 26 Nov 2014 13:51:05 +0900 (JST)
Newsgroups org.kernel.vger.stgt
Message-ID <20141126.135105.1568838937885770687.fujita.tomonori@lab.ntt.co.jp>
Hi,

On Tue, 25 Nov 2014 18:13:27 +0100 (CET)
[email protected] wrote:

> Sorry for writing directly, but this tiny typo is not
> worth the effort of subscribing.
> It prevents a deletion of entry from iqn_acl.

Thanks a lot! Applied.

You can post anything to the mailing list without subscribing.

> Regards,
> Borg
> 
> 
> diff --git a/usr/mgmt.c b/usr/mgmt.c
> index 1eae0c9..3587f4b 100644
> --- a/usr/mgmt.c
> +++ b/usr/mgmt.c
> @@ -152,7 +152,7 @@ static tgtadm_err target_mgmt(int lld_no, struct
> mgmt_task *
> mtask)
>  p = strstr(mtask->req_buf, "initiator-name=");
>  if (p) {
>         p += strlen("initiator-name=");
> -       adm_err = iqn_acl_del(req->tid, p + strlen("initiator-name="));
> +       adm_err = iqn_acl_del(req->tid, p);
>         if (adm_err != TGTADM_SUCCESS) {
>                 eprintf("Failed to unbind by name: %s\n", p);
>                 break;
>