Re: [PATCH] Handle access of a target that has been removed

Hi,

On Wed, 25 Nov 2015 21:06:14 -0800
Lee Duncan <[email protected]> wrote:

> I thought that you might like to know that I finally tested this. I

Yeah, thanks a lot for the input!

> created a test bed where I randomly created and deleted 4 target nodes
> by changing the configuration files then running "tgt-admin --update
> ALL -f".
> 
> At the same time, I randomly attempted to log out of then back into
> all 4 targets.
> 
> It only takes a minute to hit the case the patch I sent fixes, where
> target_find_by_name() dies when tgt_targetname() returns an unexpected
> NULL. It was nice to validate that the patch was actually needed.
> 
> You might remember, though, that I was worried that other places where
> tgt_targetname() where used might need to check for NULL as well. So
> I tested for that.
> 
> Surprisingly, none of the other places that uses tgt_targetname() ever
> got NULL back. I tested for several hours. So either I just didn't hit
> the corner case needed to tickle such a bug, or that just doesn't
> happen. I would love to investigate further, but I may not have the
> time to get to it soon. In the mean time, it appears we are in good
> shape.

I see. I try to think more.