Re: [PATCH] fix errno use after strtoull

FUJITA Tomonori <[email protected]> Sun, 24 Apr 2016 08:46:35 +0900 (JST)
Newsgroups org.kernel.vger.stgt
Message-ID <[email protected]>
On Thu, 21 Apr 2016 11:22:40 -0500
Ryan Harper <[email protected]> wrote:

> From 3f3991ee3345f9728928711f6be7a0020568faf6 Mon Sep 17 00:00:00 2001
> From: Stas Sergeev <[email protected]>
> Date: Thu, 18 Feb 2016 18:35:23 +0300
> Subject: [PATCH] fix errno check
> 
> errno can only be checked if the return value indicates an error.
> The result of this bug is the following:
> 
>  ./tgtd -d 1
> -d argument value '1' invalid
> Try `tgtd --help' for more information.
> 
> As can be seen, it rejects the valid parameter because errno just
> happens to be non-zero.
> ---
>  usr/util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!