Re: Resend [PATCH 2/2] convert scsi_cmnd.h macro to normal functions

OK, I agree with you. This is a very low level API. We don't need make =
a change unless it has a problem.

Meanwhile, this tgt is an excellent project for learning iSCSI.

Thank you.

/Alex

> =D4=DA 2016=C4=EA6=D4=C23=C8=D5=A3=AC=C9=CF=CE=E76:54=A3=ACFUJITA Tom=
onori <[email protected]> =D0=B4=B5=C0=A3=BA
>=20
> On Thu,  2 Jun 2016 15:17:11 +0800
> Feng Li <[email protected]> wrote:
>=20
>> From: Feng Li <[email protected]>
>>=20
>> When I read this code, I found it's hard to understand about these m=
acros.
>> I hardly find where are the definitions of some functions.
>> Therefore, I expand them to normal functions for convience.
>>=20
>> Signed-off-by: Feng Li <[email protected]>
>> ---
>> usr/scsi_cmnd.h | 298 ++++++++++++++++++++++++++++++++--------------=
----------
>> 1 file changed, 170 insertions(+), 128 deletions(-)
>=20
> Sorry, I'm not inclined to apply this.
>=20
> I agree that it's hard to understand these macros however it has been
> working. Also it's unlikely that we would need to change them
> frequently. So I want to avoid change the working code just for
> readability.