Re: tgt on arm64 and USE_SIGNALFD

Andreas Hasenack <[email protected]> Thu, 15 Feb 2024 10:39:43 -0300
Newsgroups org.kernel.vger.stgt
Message-ID <CANYNYEHY=t+f7oV0A-+3faAgiSzb90mp6KB7XF2k=bVgpR_3dg@mail.gmail.com>
Hello,

On Wed, Feb 14, 2024 at 9:26=E2=80=AFPM FUJITA Tomonori
<[email protected]> wrote:
>
> Hi,
>
> On Wed, 14 Feb 2024 17:14:42 -0300
> Andreas Hasenack <[email protected]> wrote:
>
> > is USE_SIGNALFD meant to be supported on arm64? The check in
> > bs/util.h[1] is looking for __NR_signalfd, but arm64 only has the
> > newer __NR_signalfd4[2]:
> >
> > #if defined(__NR_signalfd) && defined(USE_SIGNALFD)
> > ...
> > #else
> > #define __signalfd(fd, mask, flags) (-1)
> > struct signalfd_siginfo {
> > };
> > #endif
>
> I think that we don't need this hack anymore (it was necessary when
> the signalfd feature was introduced). I've not tested on arm64 but
> I guess that simply using sys/signalfd.h works like the following?

Yes, thank you, that worked just fine!