Re: [PATCH v4 07/21] mm: have mmap_action_complete() handle the rmap lock and unmap
"Vlastimil Babka (SUSE)" <[email protected]> Tue, 24 Mar 2026 15:38:01 +0100
| Newsgroups | org.kernel.vger.target-devel,dev.linux.lists.linux-staging,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mtd,org.kernel.vger.linux-doc,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-kernel,org.kernel.vger.linux-scsi,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 3/20/26 23:39, Lorenzo Stoakes (Oracle) wrote: > Rather than have the callers handle this both the rmap lock release and > unmapping the VMA on error, handle it within the mmap_action_complete() > logic where it makes sense to, being careful not to unlock twice. > > This simplifies the logic and makes it harder to make mistake with this, > while retaining correct behaviour with regard to avoiding deadlocks. > > Also replace the call_action_complete() function with a direct invocation > of mmap_action_complete() as the abstraction is no longer required. > > Also update the VMA tests to reflect this change. > > Signed-off-by: Lorenzo Stoakes (Oracle) <[email protected]> Nice simplification. Acked-by: Vlastimil Babka (SUSE) <[email protected]>