Re: [PATCH] scsi: target: iblock: Fix wrong PR ops NULL check for PREEMPT/RELEASE

Mike Christie <[email protected]> Fri, 24 Jul 2026 13:33:19 -0500
Newsgroups org.kernel.vger.target-devel,org.kernel.vger.linux-scsi
Message-ID <[email protected]>

On 7/24/26 2:58 AM, [email protected] wrote:
> From: TanZheng <[email protected]>
> 
> In the iblock_execute_pr_out function, PRO_PREEMPT, PRO_PREEMPT_AND_ABORT
> and PRO_RELEASE all perform callback capability checks through
> ops->pr_clear. The error check allows unimplemented hooks to pass through
> the gate, resulting  dereferencing a NULL function pointer.
> 
> Check whether the hooks that need to be called are supported.
> 
> Fixes: 394f81184882 ("scsi: target: Add block PR support to iblock")
> Signed-off-by: TanZheng <[email protected]>

Reviewed-by: Mike Christie <[email protected]>