Re: [PATCH 6/6] wired syscall parameters logging function into syscall (this should fix stack smash bug detected)
Dave Jones <[email protected]>
| Newsgroups | org.kernel.vger.trinity |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Oct 08, 2013 at 02:26:55PM -0700, Ildar Muslukhov wrote:
> diff --git a/log.c b/log.c
> index 2a9c140..6340d59 100644
> --- a/log.c
> +++ b/log.c
> @@ -133,6 +133,68 @@ void synclogs(void)
>
> static void output_arg(unsigned int call, unsigned int argnum, const char *name, unsigned long oldreg, unsigned long reg, int type, FILE *fd, bool mono)
> {
> + if (syscalls[call].entry->num_args >= argnum) {
> + if (!name)
> + return;
> +
> + if (argnum != 1) {
> + CRESETFD
oh, you add it in the next patch.. this won't work. Patch series need
to be functional at every step, or the ability to use git-bisect breaks.
Dave