Re: [PATCH 4/6] wired in output function instead of printf (and some missing outputstd)
Dave Jones <[email protected]>
| Newsgroups | org.kernel.vger.trinity |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Oct 09, 2013 at 12:23:36PM -0400, Dave Jones wrote:
> On Tue, Oct 08, 2013 at 02:26:53PM -0700, Ildar Muslukhov wrote:
>
>
> > void set_seed(unsigned int pidslot)
> > {
> > + pid_t pid = getpid();
> > + if ((pid != watchdog_pid) && (pid != initpid) && (pid != mainpid))
>
> As a follow-on patch, I suggest splitting this out into an is_child_pid() helper.
on second thought, the printing of the seed from the child is a) pointless because
we can infer it from the main seed, and b) really noisy (especially when you run a lot of children).
let's drop this chunk
Dave