Re: [PATCH 04/12] configure.sh: show error output when something is not found

Dave Jones <[email protected]>
Newsgroups org.kernel.vger.trinity
Message-ID <[email protected]>
On Fri, Oct 18, 2013 at 02:00:19PM -0400, Dave Jones wrote:
 > On Wed, Oct 16, 2013 at 01:43:22PM +0300, Mikko Rapeli wrote:
 >  > It can be a configuration or ortherwise important warning/error.
 >  > 
 >  > Signed-off-by: Mikko Rapeli <[email protected]>
 >  
 > I don't like this one, because in most cases, these aren't important.
 > On some machines, we even expect some of them to fail. Example, on a Fedora 19
 > system we run this test, which we expect to fail..
 > 
 > 
 > [*] Checking if glibc headers provide termios2..  [NO] 
 > /home/davej/tmp/tmp.U0xuPLOakW.c: In function ‘main’:
 > /home/davej/tmp/tmp.U0xuPLOakW.c:7:18: error: storage size of ‘test’ isn’t known
 >   struct termios2 test;
 >                   ^
 > 
 > Printing out an 'error' when there's nothing actually wrong seems alarmist.
 > Especially when we do the right thing, and include the right header afterwards.

[PATCH 05/12] configure.sh: support cross compilation with sysroot 
will need rebasing without this. I applied and pushed out everything else.

	Dave
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.