Re: [PATCH] ip_tunnel: fix panic in ip_tunnel_xmit()
David Miller <[email protected]>
| Newsgroups | org.kernel.vger.trinity,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
From: Eric Dumazet <[email protected]> Date: Mon, 03 Feb 2014 12:52:14 -0800 > From: Eric Dumazet <[email protected]> > > Setting rt variable to NULL at the beginning of ip_tunnel_xmit() > missed possible use of this variable as a scratch value. > > Also fixes a possible dst leak in tunnel_dst_check() : > If we had to call tunnel_dst_reset(), we forgot to > release the reference on dst. > > Merges tunnel_dst_get()/tunnel_dst_check() into > a single tunnel_rtable_get() function for clarity. > > Many thanks to Tommi for his report and tests. > > Fixes: 7d442fab0a67 ("ipv4: Cache dst in tunnels)" > Reported-by: Tommi Rantala <[email protected]> > Signed-off-by: Eric Dumazet <[email protected]> > Tested-by: Tommi Rantala <[email protected]> > Cc: Tom Herbert <[email protected]> > Cc: Maciej ¯enczykowski <[email protected]> Applied, thanks Eric.