Re: [PATCH net v2] ipv6: fix rtnl locking in setsockopt for anycast and multicast

David Miller <[email protected]> Fri, 05 Sep 2014 11:53:05 -0700 (PDT)

Newsgroups	org.kernel.vger.trinity,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID	<[email protected]>

From: Sabrina Dubroca <[email protected]>
Date: Tue, 2 Sep 2014 10:29:29 +0200

> Calling setsockopt with IPV6_JOIN_ANYCAST or IPV6_LEAVE_ANYCAST
> triggers the assertion in addrconf_join_solict()/addrconf_leave_solict()
> 
> ipv6_sock_ac_join(), ipv6_sock_ac_drop(), ipv6_sock_ac_close() need to
> take RTNL before calling ipv6_dev_ac_inc/dec. Same thing with
> ipv6_sock_mc_join(), ipv6_sock_mc_drop(), ipv6_sock_mc_close() before
> calling ipv6_dev_mc_inc/dec.
> 
> This patch moves ASSERT_RTNL() up a level in the call stack.
> 
> Signed-off-by: Cong Wang <[email protected]>
> Signed-off-by: Sabrina Dubroca <[email protected]>
> Reported-by: Tommi Rantala <[email protected]>

Applied and queued up for -stable, thanks.