Re: [PATCH 5/6] fix warning on test_ti_thread_flag()
Paul Mackerras <[email protected]> Thu, 26 Jan 2006 04:12:37 +0000
| Newsgroups | org.kernel.vger.ultralinux,org.kernel.vger.linux-ia64,org.kernel.vger.linux-kernel,org.kernel.vger.sparclinux,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
Akinobu Mita writes: > I can fix this without changing the flags size for those architectures. > > 1. Introduce *_le_bit() bit operations which takes void *addr > (already I have these functions in the scope of > HAVE_ARCH_EXT2_NON_ATOMIC_BITOPS in my patch) > > 2. Change flags to __u8 flags[4] or __u8 flags[8] for each architectures. > > 3. Use *_le_bit() in include/linux/thread_info.h Please don't do this, you'll break the powerpc assembly code that tests bits in thread_info()->flags. Paul.