Re: [patch 15/44] generic ext2_{set,clear,test,find_first_zero,find_next_zero}_bit()
[email protected] (Akinobu Mita) Mon, 06 Feb 2006 11:47:02 +0000
| Newsgroups | org.kernel.vger.ultralinux,org.kernel.vger.linux-ia64,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.sparclinux |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Feb 01, 2006 at 12:27:38PM +0100, Roman Zippel wrote:
> > +static __inline__ int generic_test_le_bit(unsigned long nr,
> > + __const__ unsigned long *addr)
> > +{
> > + __const__ unsigned char *tmp = (__const__ unsigned char *) addr;
> > + return (tmp[nr >> 3] >> (nr & 7)) & 1;
> > +}
>
> The underscores are not needed.
>
Thanks, I converted to 'inline' and 'const'.