Re: [PATCH] hwclock: Support GNU Hurd
Samuel Thibault <[email protected]>
| Newsgroups | org.kernel.vger.util-linux |
|---|---|
| Organization | I am not organized |
| Message-ID | <Z1bIJjzgosmfF4xL@begin> |
Karel Zak, le lun. 09 déc. 2024 11:32:33 +0100, a ecrit:
> On Mon, Dec 09, 2024 at 10:58:15AM GMT, Zhaoming Luo wrote:
> > if (ctl->rtc_dev_name) {
> > rtc_dev_name = ctl->rtc_dev_name;
> > - rtc_dev_fd = open(rtc_dev_name, O_RDONLY);
> > + rtc_dev_fd = open(rtc_dev_name, O_RDWR);
>
> Why do you need O_RDWR on HURD?
For setting the time, it makes sense to request WR?
> Maybe it would be better to add an
> #ifdef, as it is unnecessary for Linux.
I have to say I'm surprised that Linux doesn't require it for setting
the time.
Samuel