Re: [PATCH] logger: do not show arguments of --socket-errors as optional in --help

On Mon, Jan 27, 2025 at 12:08:25PM GMT, Benno Schulenberg wrote:
>  misc-utils/logger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

 Applied, thanks.

> 
> diff --git a/misc-utils/logger.c b/misc-utils/logger.c
> index f696287d7..bcdff0614 100644
> --- a/misc-utils/logger.c
> +++ b/misc-utils/logger.c
> @@ -1101,7 +1101,7 @@ static void __attribute__((__noreturn__)) usage(void)
>  	fputs(_("     --sd-param <data>    rfc5424 structured data name=value\n"), out);
>  	fputs(_("     --msgid <msgid>      set rfc5424 message id field\n"), out);
>  	fputs(_(" -u, --socket <socket>    write to this Unix socket\n"), out);
> -	fputs(_("     --socket-errors[=<on|off|auto>]\n"
> +	fputs(_("     --socket-errors on|off|auto\n"
>  		"                          print connection errors when using Unix sockets\n"), out);

I don't have a strong opinion about it, but in other places we see
something like:

   --socket-errors <mode>   print connection errors when using Unix sockets (on, off or auto)


Note: I have also fixed the man page where we had [=mode] as well.

    Karel


-- 
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com