Re: [PATCH 05/10] irqtop: improve several more option descriptions, and align them all
Karel Zak <[email protected]>
| Newsgroups | org.kernel.vger.util-linux |
|---|---|
| Message-ID | <nvr7vxglqy3r5ody4gnuz5eouwo3j5d2w7edl2rtbemdnddjue@s5twzwylm4zf> |
On Tue, Apr 01, 2025 at 11:17:47AM +0200, Benno Schulenberg wrote:
>
> Op 31-03-2025 om 18:12 schreef Joe Jin:
> > > > Why remove the "Q"?
> > >
> > > It looks ugly. And why would the user want to hold Shift before pressing q,
> > > when just pressing q will do? Holding Shift has no extra effect.
> >
> > Then should it be removed from parse_input() as well?
>
> No, there it should stay, to accommodate users that for some reason
> have CapsLock engaged.
>
> I would propose the opposite change: to accept also the uppercase I,
> T, D, and N for sorting the table on the corresponding column.
I prefer your current version of the patch (keep Q usable for backward
compatibility, but don't announce it in the docs/help). I don't think
we need to extend support for uppercase letters. The letters are rare, so
save them for the future :-)
Karel
--
Karel Zak <[email protected]>
http://karelzak.blogspot.com